Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cdm 4 to cdm-core 5 #3788

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Upgrade cdm 4 to cdm-core 5 #3788

merged 5 commits into from
Mar 9, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Feb 28, 2022

Bump version to 5.3.3

@dgault
Copy link
Member

dgault commented Mar 1, 2022

Hopefully the changes here are somewhat limited. Modified the expected test values based on the new version:

Previous variables for /HDF4_PALGROUP/HDF4_PALETTE_2:

[CLASS, PALETTE]
[HDF4_OBJECT_TYPE, palette]
[HDF4_REF_NUM, 2]
[PAL_COLORMODEL, RGB]
[PAL_TYPE, STANDARD8]
[PAL_VERSION, 1.2]
[_Unsigned, true]

Previous variables for /Raster_Image_#0:

[CLASS, IMAGE]
[HDF4_IMAGE_LABEL_0, brs_data]
[HDF4_OBJECT_NAME, Raster Image #0]
[HDF4_OBJECT_TYPE, raster8]
[HDF4_PALETTE_LIST, /HDF4_PALGROUP/HDF4_PALETTE_2]
[HDF4_REF_NUM, 2]
[IMAGE_SUBCLASS, IMAGE_INDEXED]
[IMAGE_VERSION, 1.2]
[PALETTE, 1680]
[_Unsigned, true]

New variables for /HDF4_PALGROUP/HDF4_PALETTE_2:

PAL_COLORMODEL=RGB
HDF4_REF_NUM=2
CLASS=PALETTE
PAL_VERSION=1.2
HDF4_OBJECT_TYPE=palette
PAL_TYPE=STANDARD8

New variables for /Raster_Image_#0:

HDF4_IMAGE_LABEL_0=brs_data
HDF4_OBJECT_TYPE=raster8
IMAGE_SUBCLASS=IMAGE_INDEXED
IMAGE_VERSION=1.2
PALETTE=1680
HDF4_PALETTE_LIST=/HDF4_PALGROUP/HDF4_PALETTE_2
HDF4_OBJECT_NAME=Raster Image #2833 
CLASS=IMAGE
HDF4_REF_NUM=2

@sbesson
Copy link
Member

sbesson commented Mar 2, 2022

From https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/172304/console, this seems to have affected the reading of MINC files (which are using the NetCDFService) with a NPE

@jburel jburel mentioned this pull request Mar 3, 2022
Closed
@dgault
Copy link
Member

dgault commented Mar 9, 2022

Builds and repo tests have been green on merge CI with this PR included.

Manually testing of Minc, Imaris and Veeco files produced expected results with no obvious issues or regressions.

FIJI is currently using version 4.6.13, though from testing there seems to be no problem with the MINC changes and this version.

PR looks good to merge.

@dgault dgault added this to the 6.9.1 milestone Mar 9, 2022
@dgault dgault merged commit ef26436 into ome:develop Mar 9, 2022
@sbesson sbesson changed the title bump version Upgrade cdm 4 to cdm-core 5 Mar 14, 2022
This was referenced Mar 14, 2022
Merged
Closed
This was referenced Apr 20, 2022
Merged
Closed
@sbesson sbesson mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @dgault @sbesson